Messages in this thread |  | | Date | Thu, 28 Nov 2013 17:10:39 +0530 | Subject | Re: [PATCH v2] cpufreq: exynos: Convert exynos-cpufreq to platform driver | From | Sachin Kamat <> |
| |
Hi Lukasz,
On 28 November 2013 17:05, Lukasz Majewski <l.majewski@samsung.com> wrote: > To make the driver multiplatform-friendly, unconditional initialization > in an initcall is replaced with a platform driver probed only if > respective platform device is registered. > > Tested at: Exynos4210 (TRATS) and Exynos4412 (TRATS2) > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > --- > Changes for v2: > - Proper definition of exynos_cpufreq_init() function to squash warnings
Looks good. Just one minor nit which I forgot to mention earlier.
[snip]
> > -static int __init exynos_cpufreq_init(void) > +static int exynos_cpufreq_init(struct platform_device *pdev)
How about renaming this function to exynos_cpufreq_probe?
-- With warm regards, Sachin
|  |