Messages in this thread | | | Subject | Re: [PATCH] WIFI: handle a neglected case in nl80211_new_interface() | From | Chao Bi <> | Date | Thu, 28 Nov 2013 13:21:37 +0800 |
| |
On Thu, 2013-11-28 at 11:53 +0800, Chao Bi wrote: > On Wed, 2013-11-27 at 20:43 +0530, Ujjal Roy wrote: > > Hi, > > > > > > We can use IS_ERR_OR_NULL(wdev) to check NULL as well as error value. > > > > Thanks, > > UjjaL > > > > On Wed, Nov 27, 2013 at 8:30 AM, Chao Bi <chao.bi@intel.com> wrote: > > In nl80211_new_interface(), it calls rdev_add_virtual_intf() to create > > a new interface, however, it only checks whether returned value is err > > code, but doesn't check if returned value is NULL. The returned > > Thanks Ujjal. I'll update it. > Hi all, This patch is not valid, I further check the nl80211 API introduce, don't need to handle this NULL return value because it bans NULL feedback of add_virtual_intf() API in cfg80211.h.
| |