Messages in this thread | | | Date | Wed, 27 Nov 2013 19:53:17 +0000 | From | Matthew Garrett <> | Subject | Re: [PATCH] PCI: Clear Bus Master bit only on kexec reboot |
| |
On Wed, Nov 27, 2013 at 12:48:42PM -0700, Khalid Aziz wrote:
> I debated between pci.h and kexec.h but pci-driver.c does not > include kexec.h and I didn't want to include a whole new file. Now I > see another problem with adding that extern declaration to pci.h - > if CONFIG_KEXEC is not set, build will fail. I should add #ifdef > CONFIG_KEXEC to the code in pci-driver.c as well. Time for v2.
You're making the behaviour of the pci code conditional on whether we're in kexec or not, so I think adding kexec.h is perfectly reasonable.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |