lkml.org 
[lkml]   [2013]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] mfd: tps6586x: add version detection
    Re-adding the list.

    Please remember to 'reply to all' when discussing patches.

    > > >> Hm, when the device is not answering on that request, the probe method
    > > >> should fail I would say. This means that the device is missing most
    > > >> likely. However, I should set the device version to TPS6586X_ANY if I
    > > >> happen to end up in the default case.
    > > >
    > > > I would say that returning an error is the sound thing to do, but I'm
    > > > missing the point of TPS6586X_ANY, as it doesn't appear to be used in
    > > > this context.
    > > >
    > >
    > > Yes, its mainly used in the regulator code later on. I do assign voltage
    > > table to TPS6586X_ANY, if its the appropriate table for any version of
    > > the device.
    >
    > <snip>
    >
    > > Ok, will change this. Setting the version to TPS6586X_ANY in the default
    > > case is anyway not a good idea since it would suppress unknown versions.
    >
    > Perhaps I should suggest to make TPS6586X_ANY a positive number then,
    > as a negative value to me indicates more of an error than a generic
    > parameter.

    --
    Lee Jones
    Linaro STMicroelectronics Landing Team Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-11-27 16:41    [W:5.618 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site