lkml.org 
[lkml]   [2013]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] efi-pstore: Make efi-pstore return a unique id
Date


> -----Original Message-----
> From: Matt Fleming [mailto:matt@console-pimps.org]
> Sent: Wednesday, November 27, 2013 6:45 AM
> To: Madper Xie
> Cc: 'linux-kernel@vger.kernel.org'; linux-efi@vger.kernel.org; matt.fleming@intel.com; Seiji Aguchi; richard@nod.at; Tony Luck
> Subject: Re: [PATCH v2] efi-pstore: Make efi-pstore return a unique id
>
> On Sat, 23 Nov, at 07:55:37PM, Madper Xie wrote:
> >
> > Pstore fs expects that backends provide a uniqued id which could avoid
> > pstore making entries as duplication or denominating entries the same
> > name. So I combine the timestamp, part and count into id.
> >
> > Signed-off-by: Madper Xie <cxie@redhat.com>
> > ---
> > drivers/firmware/efi/efi-pstore.c | 19 +++++++++++++------
> > 1 file changed, 13 insertions(+), 6 deletions(-)
>
> Thanks unless anyone complains, I'm going to apply this.
>

I'm OK with this patch based on Madper's comment below.

<snip>
So i'd like to using fixed length. My dell xps has 128kb nvram
space. and it at most store 126 pstore entries. So I think 1000 will be
a safe value for count. For part, 100 should be okay. I don't think
there will be a large kmsg and we must split it into more than 100 parts.
<snip>

> Does this need to be tagged for stable?
>

I think so.

Seiji

> --
> Matt Fleming, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2013-11-27 16:41    [W:0.146 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site