Messages in this thread | | | Date | Wed, 27 Nov 2013 15:27:26 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec |
| |
On Wed, Nov 27, 2013 at 10:27:01AM +0000, Matt Fleming wrote: > Heh, you can probably already guess what I'm going to say here...
I guessed :-)
> How about using a single function to dump the memory ranges irrespective > of whether the memory map comes from 'memmap' or 'esdata'? e.g. > something along the lines of, > > if (esdata) > print_efi_memmap(esdata->map, nr_efi_runtime_map, > sizeof(esdata->map[0])); > else > print_efi_memmap(memmap.map, memmap.nr_map, > memmap.desc_size);
And while you're at it:
WARNING: quoted string split across lines #19: FILE: arch/x86/platform/efi/efi.c:443: + pr_info("mem%02u: type=%u, attr=0x%llx, " + "range=[0x%016llx-0x%016llx) (%lluMB)\n",
Btw, do we really want to dump the same map again in the second kernel?
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |