lkml.org 
[lkml]   [2013]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:sched/core] tasks/fork: Remove unnecessary child->exit_state
    Commit-ID:  bb8cbbfee68518796df4050868e5b0f5ad078f9f
    Gitweb: http://git.kernel.org/tip/bb8cbbfee68518796df4050868e5b0f5ad078f9f
    Author: Oleg Nesterov <oleg@redhat.com>
    AuthorDate: Wed, 13 Nov 2013 15:36:12 +0100
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitDate: Wed, 27 Nov 2013 13:50:50 +0100

    tasks/fork: Remove unnecessary child->exit_state

    A zombie task obviously can't fork(), remove the unnecessary
    initialization of child->exit_state. It is zero anyway after
    dup_task_struct().

    Note: copy_process() is huge and it has a lot of chaotic
    initializations, probably it makes sense to move them into the
    new helper called by dup_task_struct().

    Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    Cc: David Laight <David.Laight@ACULAB.COM>
    Cc: Geert Uytterhoeven <geert@linux-m68k.org>
    Cc: Tejun Heo <tj@kernel.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/20131113143612.GA10540@redhat.com
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    kernel/fork.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/kernel/fork.c b/kernel/fork.c
    index 728d5be..b308082 100644
    --- a/kernel/fork.c
    +++ b/kernel/fork.c
    @@ -1402,13 +1402,11 @@ static struct task_struct *copy_process(unsigned long clone_flags,
    p->tgid = p->pid;
    }

    - p->pdeath_signal = 0;
    - p->exit_state = 0;
    -
    p->nr_dirtied = 0;
    p->nr_dirtied_pause = 128 >> (PAGE_SHIFT - 10);
    p->dirty_paused_when = 0;

    + p->pdeath_signal = 0;
    INIT_LIST_HEAD(&p->thread_group);
    p->task_works = NULL;


    \
     
     \ /
      Last update: 2013-11-27 15:41    [W:5.894 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site