lkml.org 
[lkml]   [2013]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 005/116] USB: mos7840: fix tiocmget error handling
    Date
    3.12-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <jhovold@gmail.com>

    commit a91ccd26e75235d86248d018fe3779732bcafd8d upstream.

    Make sure to return errors from tiocmget rather than rely on
    uninitialised stack data.

    Signed-off-by: Johan Hovold <jhovold@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/serial/mos7840.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/usb/serial/mos7840.c
    +++ b/drivers/usb/serial/mos7840.c
    @@ -1532,7 +1532,11 @@ static int mos7840_tiocmget(struct tty_s
    return -ENODEV;

    status = mos7840_get_uart_reg(port, MODEM_STATUS_REGISTER, &msr);
    + if (status != 1)
    + return -EIO;
    status = mos7840_get_uart_reg(port, MODEM_CONTROL_REGISTER, &mcr);
    + if (status != 1)
    + return -EIO;
    result = ((mcr & MCR_DTR) ? TIOCM_DTR : 0)
    | ((mcr & MCR_RTS) ? TIOCM_RTS : 0)
    | ((mcr & MCR_LOOPBACK) ? TIOCM_LOOP : 0)



    \
     
     \ /
      Last update: 2013-11-27 08:41    [W:4.107 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site