Messages in this thread | | | Date | Tue, 26 Nov 2013 17:59:54 -0700 | From | Jens Axboe <> | Subject | Re: [GIT PULL] Immutable biovecs |
| |
On Tue, Nov 26 2013, Kent Overstreet wrote: > On Mon, Nov 25, 2013 at 10:05:58PM -0800, Christoph Hellwig wrote: > > On Mon, Nov 25, 2013 at 01:52:16PM -0800, Kent Overstreet wrote: > > > Jens - here's immutable biovecs, rebased and ready for 3.14. Changes since the > > > last version of the series: > > > > Can you do a resend of the patch series to all involved lists first so > > we can have a detailed look at the current version? > > Sure thing. > > > > * bio_clone_bioset() retains the old behaviour, as previously discussed - > > > bio_clone_fast() is being used by bcache, dm and the new bio_split(). > > > > Any chance to have a more descriptive name than bio_clone_fast? Also > > without having the actual patches in front of me, did you make sure to > > document the different in semantics in detail? > > I haven't been able to think of anything I don't hate, I'm open to > suggestions.
Don't think it's super important, as it will die off pretty quickly anyway. _fast implies it takes certain shortcuts and you need to be more careful, so I don't think it's that bad.
-- Jens Axboe
| |