Messages in this thread | | | Date | Tue, 26 Nov 2013 18:15:32 -0800 | Subject | Re: [PATCH v2 03/10] PCI: Move resources and bus_list releasing to pci_release_dev | From | Yinghai Lu <> |
| |
On Tue, Nov 26, 2013 at 5:15 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: >> @@ -36,11 +22,6 @@ static void pci_destroy_dev(struct pci_dev *dev) >> { >> device_del(&dev->dev); >> >> - down_write(&pci_bus_sem); >> - list_del(&dev->bus_list); >> - up_write(&pci_bus_sem); >> - >> - pci_free_resources(dev); >> put_device(&dev->dev); > > And if the side effects are benign enough, why don't we do a device_unregister() > here?
Yes, that is same, but we are using device_add in pci_device_add...
Thanks
Yinghai
| |