Messages in this thread | | | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH] rtc: s5m-rtc: Fix info->rtc assignment | Date | Tue, 26 Nov 2013 10:17:47 +0100 |
| |
On 11/15/2013 12:54 PM, Geert Uytterhoeven wrote: > drivers/rtc/rtc-s5m.c: In function ‘s5m_rtc_probe’: > drivers/rtc/rtc-s5m.c:545: warning: assignment from incompatible pointer type > > struct s5m_rtc_info.rtc has type "struct regmap *", while > struct sec_pmic_dev.rtc has type "struct i2c_client *". > > Probably the author wanted to assign "struct sec_pmic_dev.regmap", which > has the correct type. > > Also, as "rtc" doesn't make much sense as a name for a regmap, rename it to > "regmap". > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > I would be really surprised if this driver didn't just crash... > Please test. Thanks! > > drivers/rtc/rtc-s5m.c | 54 ++++++++++++++++++++++++------------------------- > 1 file changed, 27 insertions(+), 27 deletions(-)
Seems good, tested on device with S5M8767.
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards, Krzysztof
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |