lkml.org 
[lkml]   [2013]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] gpio: pl061: print resource_size_t as %pa
From
On Tue, Nov 26, 2013 at 8:17 PM, Olof Johansson <olof@lixom.net> wrote:
> On Tue, Nov 26, 2013 at 11:14 AM, Joe Perches <joe@perches.com> wrote:
>> On Tue, 2013-11-26 at 10:56 -0800, Olof Johansson wrote:

>>> amba_set_drvdata(adev, chip);
>>> - dev_err(&adev->dev, "PL061 GPIO chip @%08x registered\n",
>>> - adev->res.start);
>>> + dev_err(&adev->dev, "PL061 GPIO chip @%pa registered\n",
>>> + &adev->res.start);
>>
>> This looks as if this should not use dev_err, but maybe dev_info
>> and maybe it should use %pR, &adev->res
>
> Yep, I have as a somewhat long-standing todo to scrub for needlessly
> elevated printk levels (err and warn) on various drivers during boot,
> thanks for shortcutting that. :)

Bah copy/paste bug from my side ...

> I'll let Linus decide on pR vs pa.

I go with the thing you tested, fixed up the commit and also
switched to dev_info().

But now I have worse PL061 problems than this.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-11-27 01:21    [W:0.055 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site