lkml.org 
[lkml]   [2013]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] block: Make generic_make_request handle arbitrary sized bios
On Mon, Nov 25, 2013 at 10:09:21PM -0800, Christoph Hellwig wrote:
> > + q->bio_split = bioset_create(4, 0);
> > + if (!q->bio_split)
> > + goto fail_id;
>
> How did we arrive at a mempool size of 4 to make sure we can always make
> progress with arbitrarily sized bios? Shouldn't we document the design
> decision somewhere?

It just has to be nonzero to guarantee forward progress - the
bio_alloc_bioset() rescuer thing I did awhile back guarantees that.

> > +static struct bio *blk_bio_discard_split(struct request_queue *q,
> > + struct bio *bio,
> > + struct bio_set *bs)
> > +{
>
> One fallout of this should be that it would allows us to impement
> a range UNMAP/TRIP much more easily, which would help dramatically
> with TRIM performance!

Cool!


\
 
 \ /
  Last update: 2013-11-26 08:41    [W:0.608 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site