lkml.org 
[lkml]   [2013]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/12] mtd: nand: davinci: adjust DT properties to MTD generic
On Monday 11 November 2013 10:31 PM, Khoronzhuk, Ivan wrote:
> The properties davinci-ecc-mode, davinci-nand-use-bbt, davinci-nand-buswidth
> are MTD generic. Correct names for them are: nand-ecc-mode, nand-on-flash-bbt,
> nand-bus-width accordingly. So rename them in dts and documentation.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
> .../devicetree/bindings/mtd/davinci-nand.txt | 25 ++++++++++++++++----
> drivers/mtd/nand/davinci_nand.c | 11 ++++++---
> 2 files changed, 28 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/davinci-nand.txt b/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> index d2a3fc0..befaa5b 100644
> --- a/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> @@ -37,7 +37,7 @@ Recommended properties :
> - ti,davinci-mask-chipsel: mask for chipselect address. Needed to mask
> addresses for given chipselect.
>
> -- ti,davinci-ecc-mode: operation mode of the NAND ecc mode. ECC mode
> +- nand-ecc-mode: operation mode of the NAND ecc mode. ECC mode
> valid values for davinci driver:
> - "none"
> - "soft"
> @@ -45,10 +45,25 @@ Recommended properties :
>
> - ti,davinci-ecc-bits: used ECC bits, currently supported 1 or 4.
>
> -- ti,davinci-nand-buswidth: buswidth 8 or 16.

Shouldn't we keep the documentation for existing bindings while just
marking them as deprecated?

Thanks,
Sekhar



\
 
 \ /
  Last update: 2013-11-26 08:41    [W:0.103 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site