lkml.org 
[lkml]   [2013]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] checkpatch: add DT compatible string documentation check
On 11/26/2013 11:29 AM, Joe Perches wrote:
> On Tue, 2013-11-26 at 11:11 -0600, Rob Herring wrote:
>> I think we don't really want '+' (or '_') in compatible strings.
>
> What about lines like:
> arch/powerpc/boot/dts/kmeter1.dts: compatible = "ucc_geth";

I didn't say we don't have them, but for new bindings we want to flag
things like this. It is fine if new dts files use those existing
bindings, but no one should be creating new bindings with the deprecated
style. The problem is that I can't really automate this check on the
binding documentation until we move to schema based bindings (which
won't be soon). So I would like to warn if dts files use deprecated
styles. I don't expect this to be a frequent occurrence.

Rob



\
 
 \ /
  Last update: 2013-11-26 19:01    [W:0.767 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site