lkml.org 
[lkml]   [2013]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [PATCH V3 4/6] cpufreq: exynos: Use cpufreq_generic_suspend()
From
On 25 November 2013 19:41, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> Currently we have implemented PM notifiers to disable/enable ->target() routines
> functionality during suspend/resume.
>
> Now we have support present in cpufreq core, lets use it.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/exynos-cpufreq.c | 97 +++-------------------------------------
> 1 file changed, 6 insertions(+), 91 deletions(-)

Jonghwan Choi reported an issue with this patch. He asked me
to look at: 6e45eb

And so following diff is updated for this patch in my repo.. Will get
that fixed in V4:

diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index 4b6e6a6..3f216da 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -22,8 +22,8 @@
#include "exynos-cpufreq.h"

static struct exynos_dvfs_info *exynos_info;
-
static struct regulator *arm_regulator;
+static unsigned int locking_frequency;

static int exynos_cpufreq_get_index(unsigned int freq)
{
@@ -134,7 +134,7 @@ static int exynos_target(struct cpufreq_policy
*policy, unsigned int index)
static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy)
{
policy->clk = exynos_info->cpu_clk;
- policy->suspend_freq = clk_get_rate(exynos_info->cpu_clk) / 1000;
+ policy->suspend_freq = locking_frequency;
return cpufreq_generic_init(policy, exynos_info->freq_table, 100000);
}

@@ -182,6 +182,9 @@ static int __init exynos_cpufreq_init(void)
goto err_vdd_arm;
}

+ /* Done here as we want to capture boot frequency */
+ locking_frequency = clk_get_rate(exynos_info->cpu_clk) / 1000;
+
if (!cpufreq_register_driver(&exynos_driver))
return 0;

\
 
 \ /
  Last update: 2013-11-26 16:01    [W:0.027 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site