Messages in this thread | | | Date | Tue, 26 Nov 2013 12:57:26 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] remove CONFIG_SCHED_HRTICK |
| |
* Christoph Hellwig <hch@infradead.org> wrote:
> It's equivalent to CONFIG_HIGH_RES_TIMERS now that all architectures > use the generic helpers it relies on.
So the SCHED_HRTICK variable documents the scheduler's dependencies here. It currently indeed clones CONFIG_HIGH_RES_TIMERS, but that's just how it's implemented today.
If we were to enable this feature more widely in the future (it's expensive right now so disabled by default at the moment) then it will be much easier to just change.
That said, while checking the background of the changes here ran across two ARM commits that I don't really like:
commit c9218b163959fafa76ffbee0baa3ef269838f410 Author: Russell King <rmk+kernel@arm.linux.org.uk> Date: Sat Apr 27 23:31:10 2013 +0100
ARM: Allow selection HZ values
this commit introduced a nonsensical duplication:
+config SCHED_HRTICK + def_bool HIGH_RES_TIMERS
config SCHED_HRTICK def_bool HIGH_RES_TIMERS
Plus:
commit b28748fb5d21d5d64c9ce31579ffbbd41f317042 Author: Russell King <rmk+kernel@arm.linux.org.uk> Date: Sun Feb 17 14:40:33 2013 +0000
ARM: add SCHED_HRTICK config option As we don't include kernel/Kconfig.hz as this defines HZ values unsuitable for ARM platforms, add the SCHED_HRTICK to properly configure the scheduler for hrtimer operation. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
... so if kernel/Kconfig.hz is 'unsuitable for ARM platforms' how about fixing it properly and making init/Kconfig.hz suitable for ARM, instead of duplicating its options in arch/arm/Kconfig in a messy fashion?
Thanks,
Ingo
| |