Messages in this thread | | | Date | Tue, 26 Nov 2013 16:59:42 +0530 | Subject | Re: [PATCH 1/2 v2] i2c: exynos5: add support for HSI2C on Exynos5260 SoC | From | Sachin Kamat <> |
| |
On 26 November 2013 09:56, Naveen Krishna Chatradhi <ch.naveen@samsung.com> wrote: > This patch adds new compatible to support HSI2C module on Exynos5260 > HSI2C module on Exynos5260 needs to be reset during during initialization. > > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> [snip] > > Required properties: > - compatible: value should be. > - -> "samsung,exynos5-hsi2c", for i2c compatible with exynos5 hsi2c. > + -> "samsung,exynos5-hsi2c", for i2c compatible with HSI2C available on > + Exynos5250/5420 SoCs.
This string could be made more specific ("samsung,exynos5250-hsi2c") now that we have variants for this.
> + -> "samsung,exynos5260-hsi2c", for i2c compatible with HSI2C available > + on Exynos5260 SoCs. > + > - reg: physical base address of the controller and length of memory mapped > region. > - interrupts: interrupt number to the cpu. > diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c > index da39ff0..497ff91 100644 > --- a/drivers/i2c/busses/i2c-exynos5.c > +++ b/drivers/i2c/busses/i2c-exynos5.c > @@ -184,14 +184,35 @@ struct exynos5_i2c { > * 2. Fast speed upto 1Mbps > */ > int speed_mode; > + > + /* Version of HS-I2C Hardware */ > + unsigned int version; > +}; > + > +enum hsi2c_version { > + EXYNOS_5,
ditto.
> + EXYNOS_5260 > }; >
-- With warm regards, Sachin
| |