Messages in this thread | | | Date | Mon, 25 Nov 2013 10:30:56 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 01/22] tools lib traceevent: Add plugin support |
| |
On Sat, Nov 23, 2013 at 03:12:19AM -0500, Steven Rostedt wrote:
SNIP
> > > + if (!handle) { > > > + warning("could not load plugin '%s'\n%s\n", > > > + plugin, dlerror()); > > > + goto out_free; > > > + } > > > + > > > + alias = dlsym(handle, PEVENT_PLUGIN_ALIAS_NAME); > > > + if (!alias) > > > + alias = file; > > > > So this 'alias' is not used anywhere in the current code, right? > > Do you plan to add the option processing soon? > > I believe he is, and hopefully he will, because I want to forward port > this code to have trace-cmd use it. The end result should be a separate > library that we all can use.
yep, thats the plan ;-)
so I get the the deal is in v2 I keep the current code and add patches addressing comments on top of it..
jirka
| |