Messages in this thread | | | Date | Mon, 25 Nov 2013 18:05:31 +0900 | From | Alex Courbot <> | Subject | Re: [PATCH v2 3/7] net: rfkill: gpio: remove gpio conversion support |
| |
On 11/25/2013 06:02 PM, Heikki Krogerus wrote: > On Mon, Nov 25, 2013 at 05:47:38PM +0900, Alex Courbot wrote: >> On 11/25/2013 05:41 PM, Heikki Krogerus wrote: >>> Adding the lookup table in first patch and then changing the driver in >>> the second creates a point to the history where this driver stops >>> working on this platform, which is something I'm not willing to do. >> >> Does it? If you just add a lookup table and keep using the >> integer-based GPIO interface, then your lookup table will not be >> used by anyone and will basically be a no-op. Then you can switch to >> the GPIO descriptor interface and take advantage of the lookup >> table. Unless I missed something there should not be any point that >> breaks in the git history. >> >> (to be clear: the first patch should *only* contain the lookup >> table, and the second be a merge of the current patches 1 and 3 of >> this series.) > > OK, I agree. If I don't remove the old gpio numbers in in the first > patch, there is no problem. We can do this with the two patches.
Yep, that's what I meant. :) It would make the series considerably easier to understand by removing its temporary code.
Thanks, Alex.
| |