Messages in this thread | | | From | Tomasz Figa <> | Subject | Re: [PATCH] watchdog: s3c2410_wdt: Only register for cpufreq on CPU_FREQ_S3C24XX | Date | Tue, 26 Nov 2013 01:16:51 +0100 |
| |
On Tuesday 26 of November 2013 00:08:31 Ben Dooks wrote: > On Mon, Nov 25, 2013 at 02:55:37PM -0800, Doug Anderson wrote: > > On modern SoCs the watchdog timer is parented on a clock that doesn't > > change every time we have a cpufreq change. That means we don't need > > to constantly adjust the watchdog timer, so avoid registering for and > > dealing with cpufreq transitions unless we've actually got > > CPU_FREQ_S3C24XX defined. > > The S3C2410 to at-least S3C2440 there is only one PLL/clock-divider > set so changing any part of that can change frequency supplied to > the watchdog.
And so we're leaving the notifier code intact, just changing the ifdef conditionm which decides whether it should be compiled in, from a (too) generic one to an S3C24xx-specific one.
Best regards, Tomasz
| |