Messages in this thread | | | Date | Mon, 25 Nov 2013 10:41:27 +0200 | From | Heikki Krogerus <> | Subject | Re: [PATCH v2 3/7] net: rfkill: gpio: remove gpio conversion support |
| |
On Sat, Nov 23, 2013 at 05:59:30PM +0900, Alexandre Courbot wrote: > Wouldn't it be possible (and simpler) to move patch 2 of your series > to first position, and then to merge patch 1 and 3 together in second > position? It seems to me that you are basically undoing much of the > work of your first patch here (notably by removing > rfkill_gpio_convert_to_desc() which ends up having a very short life) > and that this could be avoided if you defined the platform lookup > tables first. > > Doing so would avoid prevent you from using gpio_to_desc() which you > should never ever use anyway. :P
Adding the lookup table in first patch and then changing the driver in the second creates a point to the history where this driver stops working on this platform, which is something I'm not willing to do.
But, we can make one patch out of all three if everybody is OK with that.
-- heikki
| |