Messages in this thread | | | Date | Mon, 25 Nov 2013 15:01:27 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode |
| |
Hi!
On Sun 2013-11-24 20:41:46, Pali Rohár wrote: > On Sunday 24 November 2013 20:26:09 Sebastian Reichel wrote: > > On Sun, Nov 24, 2013 at 08:01:16PM +0100, Pali Rohár wrote: > > > Currently on Maemo 5 this is handled in userspace (with open > > > source dsme daemon). > > > > I assume it currently also takes care of the bq2415x watchdog? > > That means if the daemon dies charging will stop, because the > > watchdog does no longer trigger. > > > > When your patch is applied you have introduced a safety issue. > > When the daemon dies charging will continue and temperature is > > no longer checked. > > > > -- Sebastian > > No dsme checking battery temperature and does not handle bq24510 > timer (previously this was in closed bme daemon which > functionality is now in kernel drivers). But dsme daemon also > kicking tlw4030 watchdog, so when daemon dies after 30s tlw4030 > reboot device. > > But right you can implement correctly this in userspace (e.g. > when daemon not running/crashed, you can restart daemon or reboot > system or disable charing, whatever...) and you do not need to > have it in kernel...
Charging handling really should be in kernel.
1st) you want charging to work with init=/bin/bash, and you want it with regular (not n900-specific) debian/arm.
2st) normally hardware, firmware or kernel does the charging. (PCs, Sharp Zaurus). Yes, it pulls us farther away from Maemo...
Where can I get dsme sources? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |