lkml.org 
[lkml]   [2013]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 64/87] vfs: allow O_PATH file descriptors for fstatfs()
    3.2.53-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Linus Torvalds <torvalds@linux-foundation.org>

    commit 9d05746e7b16d8565dddbe3200faa1e669d23bbf upstream.

    Olga reported that file descriptors opened with O_PATH do not work with
    fstatfs(), found during further development of ksh93's thread support.

    There is no reason to not allow O_PATH file descriptors here (fstatfs is
    very much a path operation), so use "fdget_raw()". See commit
    55815f70147d ("vfs: make O_PATH file descriptors usable for 'fstat()'")
    for a very similar issue reported for fstat() by the same team.

    Reported-and-tested-by: ольга крыжановская <olga.kryzhanovska@gmail.com>
    Acked-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    [bwh: Backported to 3.2: use fget_raw() not fdget_raw()]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/statfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/statfs.c
    +++ b/fs/statfs.c
    @@ -86,7 +86,7 @@ int user_statfs(const char __user *pathn

    int fd_statfs(int fd, struct kstatfs *st)
    {
    - struct file *file = fget(fd);
    + struct file *file = fget_raw(fd);
    int error = -EBADF;
    if (file) {
    error = vfs_statfs(&file->f_path, st);
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-11-25 19:21    [W:4.179 / U:0.784 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site