Messages in this thread | | | Date | Mon, 25 Nov 2013 16:02:11 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 18/22] perf tools: Add udis86 disassembler feature check |
| |
On Sat, Nov 23, 2013 at 12:38:02AM +0900, Namhyung Kim wrote: > 2013-11-21 (목), 12:01 +0100, Jiri Olsa: > > Adding udis86 disassembler feature check which support > > is needed for kvm:kvm_emulate_insn tracepoint. > > > > The diff of 'perf script' output generated by old and new code: > > (data was generated by 'perf record -e kvm:kvm_emulate_insn -a') > > > > --- script.kvm.old > > +++ script.kvm.new > > - qemu-system-x86 15519 [003] 5332.470049: kvm:kvm_emulate_insn: 0:ffffffff8103c596:89 b7 00 80 5f ff (prot64) > > + qemu-system-x86 15519 [003] 5332.470049: kvm:kvm_emulate_insn: 0:ffffffff8103c596: mov %esi, -0xa08000(%rdi) > > [SNIP] > > --- a/tools/perf/Makefile.perf > > +++ b/tools/perf/Makefile.perf > > @@ -710,7 +710,7 @@ $(LIB_FILE): $(LIB_OBJS) > > # libtraceevent.a > > TE_SOURCES = $(wildcard $(TRACE_EVENT_DIR)*.[ch]) > > > > -LIBTRACEEVENT_FLAGS=$(QUIET_SUBDIR1) O=$(OUTPUT) CFLAGS="-g -Wall $(EXTRA_CFLAGS)" plugin_dir=$(plugindir_SQ) > > +LIBTRACEEVENT_FLAGS=$(QUIET_SUBDIR1) O=$(OUTPUT) CFLAGS="-g -Wall $(EXTRA_CFLAGS) $(LIBTRACEEVENT_CFLAGS)" plugin_dir=$(plugindir_SQ) > > What about breaking the line with "+="?
ok
thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |