Messages in this thread | | | Date | Mon, 25 Nov 2013 15:35:21 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/1] tracing: Introduce "pseudo registers" for FETCH_MTD_reg |
| |
On 11/25, Namhyung Kim wrote: > > On Sun, 24 Nov 2013 16:32:53 +0900, Masami Hiramatsu wrote: > > (2013/11/24 5:16), Oleg Nesterov wrote: > > > >> This syntax is %%pseudo-reg-name, I agree in advance with any other > >> naming. > > > > For this kind of use, kprobe-tracer already provides '$' prefix :) > > e.g. $stack, $retval etc. Please see parse_probe_vars in trace_probe.c. > > > > So, $current and $cpu is better for me. > > Agreed.
OK, thanks, I'll redo.
But I hope you will agree with overloading of FETCH_MTD_reg, I do not want to add yet another method.
In fact I thought about $current too, and I agree it looks better. But this conflicts with other changes I had in mind. I was going to add the support for @symbol+%reg and +%reg(...), then add the %%percpu_shift pseudo reg. But on a second thought this doesn't look very nice, so lets use $name.
Oleg.
| |