lkml.org 
[lkml]   [2013]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 33/87] netfilter: nf_ct_sip: don't drop packets with offsets pointing outside the packet
    3.2.53-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Patrick McHardy <kaber@trash.net>

    commit 3a7b21eaf4fb3c971bdb47a98f570550ddfe4471 upstream.

    Some Cisco phones create huge messages that are spread over multiple packets.
    After calculating the offset of the SIP body, it is validated to be within
    the packet and the packet is dropped otherwise. This breaks operation of
    these phones. Since connection tracking is supposed to be passive, just let
    those packets pass unmodified and untracked.

    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    [bwh: Backported to 3.2: there is no log message to delete]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    --- a/net/netfilter/nf_conntrack_sip.c
    +++ b/net/netfilter/nf_conntrack_sip.c
    @@ -1468,7 +1468,7 @@ static int sip_help_tcp(struct sk_buff *

    msglen = origlen = end - dptr;
    if (msglen > datalen)
    - return NF_DROP;
    + return NF_ACCEPT;

    ret = process_sip_msg(skb, ct, dataoff, &dptr, &msglen);
    if (ret != NF_ACCEPT)


    \
     
     \ /
      Last update: 2013-11-25 16:21    [W:4.222 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site