lkml.org 
[lkml]   [2013]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[REPOST PATCH V2] irq: enable all irqs unconditionally in irq_resume
    Date
    When system enters into suspend, it disable all irqs in single
    function call. This disables EARLY_RESUME irqs also along with
    normal irqs.

    The EARLY_RESUME irqs get enabled in sys_core_ops->resume and
    non-EARLY_RESUME irqs get enabled in normal system resume path.

    When suspend_noirq failed or suspend is aborted for any reason,
    the EARLY_RESUME irqs do not get enabled as sys_core_ops->resume()
    call did not happen. It only enables the non-EARLY_RESUME irqs in normal
    disable for remaining life of system.

    Enable all irqs unconditionally in normal irq_resume() regardless of
    EARLY_RESUME irqs have been already enabled or not.

    Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
    Acked-by-and-tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Acked-by: Heiko Stuebner <heiko@sntech.de>
    Reviewed-by: Pavel Machek <pavel@ucw.cz>

    ---
    Creating this patch based on disucssion on patch
    [PATCH] irq: enable suspended EARLY_RESUME irqs forcefully if not resumed

    Making simple change as susggested by Thomas.

    Reposting it with ack and review.

    kernel/irq/pm.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
    index cb228bf..abcd6ca 100644
    --- a/kernel/irq/pm.c
    +++ b/kernel/irq/pm.c
    @@ -50,7 +50,7 @@ static void resume_irqs(bool want_early)
    bool is_early = desc->action &&
    desc->action->flags & IRQF_EARLY_RESUME;

    - if (is_early != want_early)
    + if (!is_early && want_early)
    continue;

    raw_spin_lock_irqsave(&desc->lock, flags);
    --
    1.7.1.1


    \
     
     \ /
      Last update: 2013-11-25 16:01    [W:3.377 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site