lkml.org 
[lkml]   [2013]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 06/22] tools lib traceevent: Add kmem plugin
Date
On Sat, 23 Nov 2013 04:06:45 -0500, Steven Rostedt wrote:
> On Fri, 22 Nov 2013 23:38:17 +0900
> Namhyung Kim <namhyung@kernel.org> wrote:
>> It'd be great if the "call_site" in the output changes to display
>> function names instead of hex addresses directly.
>>
>
> Actually, that's what's in the ().
>
> kmem:kmalloc_node: (__alloc_skb+0x7e) call_site=ffffffff8153c67e
>
> This uses a short cut, where we don't overwrite the entire handler, in
> case the TP_printk() gets new fields.
>
> If the registered handler for an event, like "call_site_handler" (see
> how we use it for all of tracepoints) returns >0, that tells the
> library that we only added extra information, and to print the
> tracepoint as it is normally.

Yeah, I know. But just want to say that it'd be better if it's
displayed like below.

kmem:kmalloc_node: call_site=__alloc_skb+0x7e ...

But it requires to write new handlers for each event..

>
> The better solution here is to use "%pS" or something in the actual
> tracepoint instead.

Agreed.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-11-25 09:21    [W:0.166 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site