Messages in this thread | | | Date | Mon, 25 Nov 2013 13:14:17 +0100 | From | Oleg Nesterov <> | Subject | Re: 答复: Re: [PATCH 1/ 1] workqueue : swap set_cpus_allowed_ptr() and PF_NO_SETAFFINITY |
| |
On 11/25, zhang.yi20@zte.com.cn wrote: > > htejun@gmail.com wrote on 2013/11/23 07:13:43: > > > > > Re: [PATCH 1/1] workqueue: swap set_cpus_allowed_ptr() and PF_NO_SETAFFINITY > > > > On Thu, Nov 14, 2013 at 6:56 AM, Oleg Nesterov <oleg@redhat.com> wrote: > > > Move the setting of PF_NO_SETAFFINITY up before set_cpus_allowed() > > > in create_worker(). Otherwise userland can change ->cpus_allowed > > > in between. > > > > > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> > > > > Applied to wq/for-3.13-fixes. > > > > Thanks! > > > > -- > > tejun > > How about the first patch?
Let me quote myself:
Looks like Zhang is right... But I'd suggest to change flush_old_exec() instead (see "current->flags &= ...").
Do you agree? If yes, could you make v2? flush_old_exec() already clears the unwanted PF_ bits, I do not think we should add another place.
Oleg.
| |