Messages in this thread | | | From | Pali Rohár <> | Subject | Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode | Date | Sun, 24 Nov 2013 20:01:16 +0100 |
| |
On Sunday 24 November 2013 18:00:00 Sebastian Reichel wrote: > Hi, > > On Tue, Nov 19, 2013 at 11:18:04AM +0100, Pali Rohár wrote: > > This patch removing set_mode_hook function from board data > > and replacing it with new string variable of notifier power > > supply device. After this change it is possible to add DT > > support because driver does not need specific board > > function anymore. Only static data and name of power supply > > device is required. > > I'm wondering if the watchdog thread should check some values, > like e.g. battery temperature. It should stop charging the > battery if some critical battery temperature threshold is > reached. > > -- Sebastian
For checking battery temperature is needed third driver (rx51_battery.ko). And I think this should not be implemented in driver itself but in charger manager framework...
Currently on Maemo 5 this is handled in userspace (with open source dsme daemon).
-- Pali Rohár pali.rohar@gmail.com [unhandled content-type:application/pgp-signature] | |