Messages in this thread | | | From | Prabhakar Lad <> | Date | Mon, 25 Nov 2013 09:42:30 +0530 | Subject | Re: [PATCH v6 1/6] gpio: davinci: use readl/writel instead of __raw_* |
| |
Hi Taras,
On Fri, Nov 22, 2013 at 3:38 PM, Taras Kondratiuk <taras.kondratiuk@linaro.org> wrote: > On 21 November 2013 20:15, Prabhakar Lad <prabhakar.csengg@gmail.com> wrote: >> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> >> >> This patch replaces the __raw_readl/writel with >> readl and writel, Altough the code runs on ARMv5 >> based SOCs, changing this will help copying the code >> for other uses. > > This replacement has a functional impact: it adds memory barriers. > Please note this in the description. > Also please add a bit of explanation on why do you need to add barriers. > Agreed this adds memory barriers, I'll add a note about it.
Thanks, --Prabhakar Lad
| |