lkml.org 
[lkml]   [2013]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode
Date
On Sunday 24 November 2013 20:26:09 Sebastian Reichel wrote:
> On Sun, Nov 24, 2013 at 08:01:16PM +0100, Pali Rohár wrote:
> > Currently on Maemo 5 this is handled in userspace (with open
> > source dsme daemon).
>
> I assume it currently also takes care of the bq2415x watchdog?
> That means if the daemon dies charging will stop, because the
> watchdog does no longer trigger.
>
> When your patch is applied you have introduced a safety issue.
> When the daemon dies charging will continue and temperature is
> no longer checked.
>
> -- Sebastian

No dsme checking battery temperature and does not handle bq24510
timer (previously this was in closed bme daemon which
functionality is now in kernel drivers). But dsme daemon also
kicking tlw4030 watchdog, so when daemon dies after 30s tlw4030
reboot device.

But right you can implement correctly this in userspace (e.g.
when daemon not running/crashed, you can restart daemon or reboot
system or disable charing, whatever...) and you do not need to
have it in kernel...

--
Pali Rohár
pali.rohar@gmail.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-11-24 21:01    [W:1.031 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site