Messages in this thread | | | Date | Sat, 23 Nov 2013 20:10:56 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] CMA: Fix the phys_addr_t print types |
| |
On Sat, Nov 23, 2013 at 10:45:37PM -0500, Santosh Shilimkar wrote: > On Saturday 23 November 2013 10:44 PM, Greg Kroah-Hartman wrote: > > On Sat, Nov 23, 2013 at 10:37:01PM -0500, Santosh Shilimkar wrote: > >> @@ -250,8 +249,8 @@ int __init dma_contiguous_reserve_area(phys_addr_t size, phys_addr_t base, > >> *res_cma = cma; > >> cma_area_count++; > >> > >> - pr_info("CMA: reserved %ld MiB at %08lx\n", (unsigned long)size / SZ_1M, > >> - (unsigned long)base); > >> + pr_info("CMA: reserved %ld MiB at %pa\n", (unsigned long)size / SZ_1M, > >> + &base); > > > > Why is this pr_info() at all? That's just noise, please move it to > > pr_debug(). > > > Marek can comment better but I think its useful print to know CMA > reserved memory size.
Useful to who?
| |