lkml.org 
[lkml]   [2013]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: sctp: find the correct highest_new_tsn in sack
From
From: Vlad Yasevich <vyasevich@gmail.com>
Date: Thu, 21 Nov 2013 17:14:01 -0500

> On 11/21/2013 04:56 PM, Chang Xiangzhong wrote:
>> Function sctp_check_transmitted(transport t, ...) would iterate all of
>> transport->transmitted queue and looking for the highest __newly__ acked tsn.
>> The original algorithm would depend on the order of the assoc->transport_list
>> (in function sctp_outq_sack line 1215 - 1226). The result might not be the
>> expected due to the order of the tranport_list.
>>
>> Solution: checking if the exising is smaller than the new one before assigning
>>
>> Signed-off-by: Chang Xiangzhong <changxiangzhong@gmail.com>
>
> Good find. This has been around for since day 1. It doesn't so much
> depend on the order of the transport list, but on the order the
> transports been used. I agree it is a problem if chunks have been
> distributed across multiple transports and a singe SACK acking them all.
>
> Acked-by: Vlad Yasevich <vyasevich@gmail.com>

Applied, thanks.


\
 
 \ /
  Last update: 2013-11-24 00:01    [W:0.596 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site