Messages in this thread | | | Date | Fri, 22 Nov 2013 09:31:18 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v3 1/5] mfd: max14577: Add max14577 MFD driver core |
| |
On Fri, 22 Nov 2013, Krzysztof Kozlowski wrote:
> From: Chanwoo Choi <cw00.choi@samsung.com> > > This patch adds max14577 core/irq driver to support MUIC(Micro USB IC) > device and charger device and support irq domain method to control > internal interrupt of max14577 device. Also, this patch supports DT > binding with max14577_i2c_parse_dt(). > > The MAXIM 14577 chip contains Micro-USB Interface Circuit and Li+ Battery > Charger. It contains accessory and USB charger detection logic. It supports > USB 2.0 Hi-Speed, UART and stereo audio signals over Micro-USB connector. > > The battery charger is compliant with the USB Battery Charging Specification > Revision 1.1. It has also SFOUT LDO output for powering USB devices. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > drivers/mfd/Kconfig | 13 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/max14577.c | 241 +++++++++++++++++++++++++ > include/linux/mfd/max14577-private.h | 324 ++++++++++++++++++++++++++++++++++ > include/linux/mfd/max14577.h | 70 ++++++++ > 5 files changed, 649 insertions(+) > create mode 100644 drivers/mfd/max14577.c > create mode 100644 include/linux/mfd/max14577-private.h > create mode 100644 include/linux/mfd/max14577.h
<snip>
> +static struct mfd_cell max14577_devs[] = { > + { .name = "max14577-muic", }, > + { .name = "max14577-regulator", }, > + { .name = "max14577-charger", }, > +};
If these all support device tree, shouldn't you be populating max14577_devs[x].of_compatible too? That way the MFD core will automatically setup your dev.of_node pointers for you?
<snip>
> + max14577->vendor_id = (reg_data & 0x7); > + max14577->device_id = ((reg_data & 0xF8) >> 0x3);
I'm not too keen on these magic numbers, can you create #defines for them please? If there are any other interesting address, it might be worth creating some for those too.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |