Messages in this thread Patch in this message | | | From | Chao Yu <> | Subject | [f2fs-dev] [PATCH] f2fs: remove unneeded code in punch_hole | Date | Fri, 22 Nov 2013 16:52:50 +0800 |
| |
Because FALLOC_FL_PUNCH_HOLE flag must be ORed with FALLOC_FL_KEEP_SIZE in fallocate, so we could remove the useless 'keep size' branch code which will never be excuted in punch_hole.
Signed-off-by: Chao Yu <chao2.yu@samsung.com> Signed-off-by: Fan Li <fanofcode.li@samsung.com> --- fs/f2fs/file.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 7d714f4..0087d2a 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -499,12 +499,6 @@ static int punch_hole(struct inode *inode, loff_t offset, loff_t len, int mode) } } - if (!(mode & FALLOC_FL_KEEP_SIZE) && - i_size_read(inode) <= (offset + len)) { - i_size_write(inode, offset); - mark_inode_dirty(inode); - } - return ret; } -- 1.7.9.5
| |