Messages in this thread | | | Date | Fri, 22 Nov 2013 14:09:15 +0530 | Subject | Re: [PATCH V2] Cpufreq: Make governor data on nonboot cpus across system suspend/resume | From | Viresh Kumar <> |
| |
On 22 November 2013 13:49, Lan Tianyu <tianyu.lan@intel.com> wrote:
> I think you also are in the Cc list and replied the mail.:) > https://lkml.org/lkml/2013/11/21/273
Yeah, my reply was more about the coding style and I should have asked again on the same mail about waiting for sometime before posting V3... My fault!!
> I only saw the out-of-tree governor issue your mentioned but where they > are? How upstream kernel cares them?
That's what I said, we might not care about them. But I had issues with the design of your patch:
>>> But I don't really like the solution here. You are handling frozen for EXIT in >>> cpufreq-core and for INIT in governor. That doesn't look like the right >>> approach.
And so gave the solution I had as well.. And then said, I even don't want my solution to go in, as this can be fixed by taking adequate steps before removing non-boot CPUs and we are still in discussions for that.
I will post the short term solution that Rafael referred to as soon as possible and will discuss more with Rafael about the long term one (As Rafael pointed out).
Sorry for the confusion..
| |