lkml.org 
[lkml]   [2013]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] e1000: fix possible reset_task running after adapter down
From
Date
On Fri, 2013-11-22 at 12:20 +0400, Vladimir Davydov wrote:
> On e1000_down(), we should ensure every asynchronous work is canceled
> before proceeding. Since the watchdog_task can schedule other works
> apart from itself, it should be stopped first, but currently it is
> stopped after the reset_task. This can result in the following race
> leading to the reset_task running after the module unload:
>
> e1000_down_and_stop(): e1000_watchdog():
> ---------------------- -----------------
>
> cancel_work_sync(reset_task)
> schedule_work(reset_task)
> cancel_delayed_work_sync(watchdog_task)
>
> The patch moves cancel_delayed_work_sync(watchdog_task) at the
> beginning
> of e1000_down_and_stop() thus ensuring the race is impossible.
>
> Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
> Cc: Tushar Dave <tushar.n.dave@intel.com>
> Cc: Patrick McHardy <kaber@trash.net>
> Cc: David S. Miller <davem@davemloft.net>
> ---
> drivers/net/ethernet/intel/e1000/e1000_main.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)

I have applied your patch to my queue, thanks!
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-11-23 00:41    [W:0.037 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site