[lkml]   [2013]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/8] perf symbol: Save vmlinux or kallsyms path loaded
On 11/22/13, 11:44 AM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Nov 18, 2013 at 01:32:46PM -0700, David Ahern escreveu:
>> Save vmlinux or kallsyms path loaded using embedded default lookup (ie.,
>> not a user specified path). Upcoming perf sched timehist command requires
>> kernel symbols for properly computing idle times and prints a warning
>> if the kernel symbols are not loaded.
> What would happen if strdup failed here?

perf continues on happily. On the timehist command will question
computation of idle times which require kernel symbols.

> Why don't we undo anything done so far in this function and return an
> error?

In the notion of best effort of continuing. It's not a show stopper that
strdup failed; it's just not the filename it used for symbols.


 \ /
  Last update: 2013-11-22 20:41    [W:0.047 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site