lkml.org 
[lkml]   [2013]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] memory: ti-aemif: add bindings for AEMIF driver
    On 21:03 Wed 20 Nov     , ivan.khoronzhuk wrote:
    > On 11/20/2013 08:21 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
    > >> + the chip select signal.
    > >> + Minimum value is 1 (0 treated as 1).
    > >> +
    > >> +- ti,cs-wsetup: write setup width, ns
    > >> + Time between the beginning of a memory cycle
    > >> + and the activation of write strobe.
    > >> + Minimum value is 1 (0 treated as 1).
    > >> +
    > >> +- ti,cs-wstrobe: write strobe width, ns
    > >> + Time between the activation and deactivation of
    > >> + the write strobe.
    > >> + Minimum value is 1 (0 treated as 1).
    > >> +
    > >> +- ti,cs-whold: write hold width, ns
    > >> + Time between the deactivation of the write
    > >> + strobe and the end of the cycle (which may be
    > >> + either an address change or the deactivation of
    > >> + the chip select signal.
    > >> + Minimum value is 1 (0 treated as 1).
    > >> +
    > >> +If any of the above parameters are absent, current parameter value will be taken
    > >> +from the corresponding HW reg.
    > >> +
    > >> +The name for cs node must be in format csN, where N is the cs number.
    > >
    > > this is wired we should use reg instead to represent the cs as done for SPI
    > > or a an other property
    > >
    > > Best Regards,
    > > J.
    > >
    >
    > Ok, I will add new property cs-chipselect like following :
    >
    > ti,cs-chipselect: number of chipselect. Indicates on the
    > aemif driver which chipselect is used
    > for accessing the memory.
    > For compatibles "ti,davinci-aemif" and
    > "ti,keystone-aemif" it can be in range [0-3].
    > For compatible "ti,omap-L138-aemif" range is [2-5].
    >
    > Is it OK?

    yes

    I just have one issue the whole memory concept

    for me we should do as done on pinctrl have a phandle on the device that
    require it and handle it at device core level

    as the memory controller is not necessarely on the same bus as the memory
    device them selves

    Best Regards,
    J.
    >
    > --
    > Regards,
    > Ivan Khoronzhuk


    \
     
     \ /
      Last update: 2013-11-22 20:01    [W:2.995 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site