lkml.org 
[lkml]   [2013]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm/zswap: change params from hidden to ro
    On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote:
    > The "compressor" and "enabled" params are currently hidden,
    > this changes them to read-only, so userspace can tell if
    > zswap is enabled or not and see what compressor is in use.

    Reasonable to me.

    Acked-by: Seth Jennings <sjennings@variantweb.net>

    >
    > Signed-off-by: Dan Streetman <ddstreet@ieee.org>
    > ---
    > mm/zswap.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/mm/zswap.c b/mm/zswap.c
    > index d93510c..36b268b 100644
    > --- a/mm/zswap.c
    > +++ b/mm/zswap.c
    > @@ -77,12 +77,12 @@ static u64 zswap_duplicate_entry;
    > **********************************/
    > /* Enable/disable zswap (disabled by default, fixed at boot for now) */
    > static bool zswap_enabled __read_mostly;
    > -module_param_named(enabled, zswap_enabled, bool, 0);
    > +module_param_named(enabled, zswap_enabled, bool, 0444);
    >
    > /* Compressor to be used by zswap (fixed at boot for now) */
    > #define ZSWAP_COMPRESSOR_DEFAULT "lzo"
    > static char *zswap_compressor = ZSWAP_COMPRESSOR_DEFAULT;
    > -module_param_named(compressor, zswap_compressor, charp, 0);
    > +module_param_named(compressor, zswap_compressor, charp, 0444);
    >
    > /* The maximum percentage of memory that the compressed pool can occupy */
    > static unsigned int zswap_max_pool_percent = 20;
    > --
    > 1.8.3.1
    >
    > --
    > To unsubscribe, send a message with 'unsubscribe linux-mm' in
    > the body to majordomo@kvack.org. For more info on Linux MM,
    > see: http://www.linux-mm.org/ .
    > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>


    \
     
     \ /
      Last update: 2013-11-22 19:01    [W:4.396 / U:1.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site