| Subject | Re: [PATCH 22/22] perf tools: Overload pr_stat traceevent print function | From | Namhyung Kim <> | Date | Sat, 23 Nov 2013 00:50:31 +0900 |
| |
2013-11-21 (목), 12:01 +0100, Jiri Olsa: > The traceevent lib uses pr_stat to display all standard > info. It's defined as __weak. Overloading it with perf > version plugged into perf output system logic. > > Displaying the pr_stat stuff under '-v' option.
[SNIP] > > +/* > + * Overloading libtraceevent standard info print > + * function, display with -v in perf. > + */ > +void pr_stat(const char *fmt, ...) > +{ > + va_list args; > + > + if (verbose >= 1) { > + va_start(args, fmt); > + vfprintf(stderr, fmt, args); > + fprintf(stderr, "\n"); > + va_end(args); > + } > +}
It'd be better if it use or does same as eprintf() like other pr_* functions does.
Thanks, Namhyung
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|