lkml.org 
[lkml]   [2013]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpufreq: Make sure CPU is running on a freq from freq-table
On Friday 22 November 2013 03:13 AM, Rafael J. Wysocki wrote:
> On Thursday, November 21, 2013 09:56:32 AM Dirk Brandewie wrote:

>> The scaling driver for the CPU has already loaded and its .init procedure has
>> been called so .target better be callable.

Yeah..

>> Since the scaling driver is responsible maintaining the set of valid frequencies
>> and setting policy->cur I think it is reasonable to have the scaling driver
>> ensure that policy->cur returned from its .init

I agree..

>> and the operating frequency are
>> in sync and match one of the values in its frequency table.

Hmmm, that doesn't necessarily lie in driver's domain but maybe at a common
place like core. That's why we had this patch..

> From that I infer that we should not continue on errors here. Which also is my
> opinion.

Okay.. Code modified to return error on failure.. Will send V2 as soon as patch
is tested by Nishanth..


\
 
 \ /
  Last update: 2013-11-22 08:21    [W:0.048 / U:2.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site