lkml.org 
[lkml]   [2013]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH V2 2/2] cpufreq: Change freq before suspending governors
    Date
    On Friday, November 22, 2013 04:59:49 PM Viresh Kumar wrote:
    > Some platforms might want to change frequency before suspending governors. Like:
    > - Some platform which want to set freq to max to speed up suspend/hibernation
    > process.
    > - Some platform (like: Tegra or exynos), set this to min or bootloader's
    > frequency.
    >
    > This patch adds an option for those, so that they can specify this at call to
    > ->init(), so that cpufreq core can take care of this before suspending system.
    >
    > If this variable is not updated by ->init() then its value would be zero and so
    > core wouldn't do anything.
    >
    > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

    I don't think this is generally necessary, because the suspend/resume routines
    added by patch [1/2] will be executed very late during suspend or very early
    during resume and it shouldn't really matter what performance levels the CPUs
    are at then.

    The only exception *may* be hibernation, because the amount of time needed to
    create the image will depend on the current performance level of the boot CPU,
    but that should be an explicitly special case in my opinion.

    Thanks!

    --
    I speak only for myself.
    Rafael J. Wysocki, Intel Open Source Technology Center.


    \
     
     \ /
      Last update: 2013-11-22 13:41    [W:2.289 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site