lkml.org 
[lkml]   [2013]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip v3 00/23] kprobes: introduce NOKPROBE_SYMBOL() and general cleaning of kprobe blacklist

* Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:

> (2013/11/21 2:36), Frank Ch. Eigler wrote:

[ ... ]
> > one needs to resort to something like:
> >
> > # cat /proc/kallsyms | grep ' [tT] ' | while read addr type symbol; do
> > perf probe $symbol
> > done
> >
> > then wait for a few hours for that to finish. Then, or while the loop
> > is still running, run
> >
> > # perf record -e 'probe:*' -aR sleep 1
> >
> > to take a kernel down.
>
> Um, indeed, current blacklist is not perfect. [...]

Then it needs to be fixed ASAP!

> [...] As I reported in this series, I've found 2 more patterns. I
> guess there still have some others.
>
> But anyway, I don't think it is good to fix all such bugs in this
> series.

Fixing these bugs is far more important than any cleanup work.

We can apply the fixes together with your cleanup series to make it
all simpler, but the bug fixing absolutely needs to happen right now.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-11-21 08:41    [W:0.184 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site