lkml.org 
[lkml]   [2013]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/3] gpiolib: append SFI helpers for GPIO API
From
Date
On Thu, 2013-11-21 at 12:40 +0200, Mika Westerberg wrote:
> On Wed, Nov 20, 2013 at 04:31:35PM +0200, Andy Shevchenko wrote:
> > diff --git a/include/linux/gpio/sfi.h b/include/linux/gpio/sfi.h
> > new file mode 100644
> > index 0000000..3e111ad
> > --- /dev/null
> > +++ b/include/linux/gpio/sfi.h
> > @@ -0,0 +1,37 @@
> > +#ifndef _LINUX_SFI_GPIO_H_
> > +#define _LINUX_SFI_GPIO_H_
> > +
> > +#include <linux/err.h>
> > +#include <linux/errno.h>
> > +#include <linux/gpio/consumer.h>
> > +#include <linux/sfi.h>
> > +
> > +#ifdef CONFIG_GPIO_SFI
> > +
> > +struct gpio_desc *sfi_get_gpiod_by_name(const char *name);
>
> I'm wondering should this function be exported at all? What the drivers
> should be using is gpiod_get_xxx() APIs and not DT/ACPI/SFI specific
> interfaces.

I won't mix this with generic stuff since we have really few users of
SFI and there should be no new users at all.

> Yeah, we have the same in ACPI version but I'm planning to get rid of it
> completely.

I'm okay to move to this direction, if Linus and others are okay with
it.

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy



\
 
 \ /
  Last update: 2013-11-21 18:01    [W:0.047 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site