Messages in this thread | | | Date | Thu, 21 Nov 2013 15:15:40 +0100 | From | Juri Lelli <> | Subject | Re: [PATCH 03/14] sched: SCHED_DEADLINE structures & implementation. |
| |
On 11/20/2013 09:23 PM, Steven Rostedt wrote: > On Thu, 7 Nov 2013 14:43:37 +0100 > Juri Lelli <juri.lelli@gmail.com> wrote: > > >> +/* >> + * This function validates the new parameters of a -deadline task. >> + * We ask for the deadline not being zero, and greater or equal >> + * than the runtime. >> + */ >> +static bool >> +__checkparam_dl(const struct sched_param2 *prm) >> +{ >> + return prm && (&prm->sched_deadline) != 0 && >> + (s64)(&prm->sched_deadline - &prm->sched_runtime) >= 0; > > Patch 6 brought this to my attention. Looks like using the address of > the fields is wrong. I know patch 6 fixes this, but lets make it > correct in this patch first. >
Fixed.
Thanks,
- Juri
> >> +} >> + >> +/* >> * check the target process has a UID that matches the current process's >> */ >> static bool check_same_owner(struct task_struct *p)
| |