lkml.org 
[lkml]   [2013]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: Move fs.* to generic lib/lk/
On Thu, Nov 21, 2013 at 07:39:55AM -0500, Steven Rostedt wrote:
> Should we put libtraceevent here too? Have all kapi functionality live
> here?
>
> As libtraceevent is getting mature, we need to get it out as a real
> library soon. There is already three utilities that use it: perf,
> trace-cmd and powertop. And I've heard of others that want that
> functionatity.

Right, my intention was to have topic libraries like libtraceevent,
libkapi and libperfevent (this is the one that's following by exporting
evlist/evsel to other tools).

But I certainly see your angle of lumping *all* kernel-related
functionality together in one lib.

I dunno, I feel like leaving them split for now is better. Why? Not
polluting namespaces unnecessarily and why would tools who don't need
tracing functionality link against it.

Anyway, arguments can be made for both, but I personally prefer leaving
them separate. Unless there's a really compelling reason to have a
single lib - a reason which I cannot think of right now...

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--


\
 
 \ /
  Last update: 2013-11-21 15:21    [W:0.329 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site