lkml.org 
[lkml]   [2013]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 15/22] tools lib traceevent: Change pevent_parse_event to return event format
On Thu, Nov 21, 2013 at 08:28:41AM -0500, Steven Rostedt wrote:
> On Thu, 21 Nov 2013 12:01:13 +0100
> Jiri Olsa <jolsa@redhat.com> wrote:
>
> > Changing pevent_parse_event to return 'struct event_format',
> > for the parsed event if the return pointer is specified.
>
> Can we not change the API of pevent_parse_event(), I use it quite a bit.
>
> And yes, I'm working hard to keep what's in trace-cmd and the kernel
> identical.
>
> >
> > This way we can remove pevent_parse_format which does the
> > same stuff just without 'struct pevent' object.
>
> Actually, I don't use pevent_parse_format() at all. What about changing
> that one to include the pevent?
>
>
> >
> > The ultimate goal is to always use pevent object when dealing
> > with traceevent library. The reason is that we might need
> > additional processing (like plugins), which is not possible
> > otherwise.
>
> Right, so add a pevent to the pevent_parse_format() and leave the
> pevent_parse_event() alone. That should make everyone happy :-)

ook, np ;-)

thanks,
jirka


\
 
 \ /
  Last update: 2013-11-21 15:21    [W:0.266 / U:0.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site